Feature/prd 1032 Token authentication by adrian-situm · Pull Request #645 · situmtech/react-native

adrian-situm · 2026-07-10T10:52:58Z

No description provided.

Automatic merge into master to Release 3.18.6

Automatic merge into master to Release 3.18.7

Automatic merge into master to Release 3.18.8

Automatic merge into master to Release 3.18.9

Automatic merge into master to Release 3.18.10

Automatic merge into master to Release 3.18.11

Automatic merge into master to Release 3.18.12

Automatic merge into master to Release 3.18.13

Automatic merge into master to Release 3.18.14

Automatic merge into master to Release 3.18.15

Automatic merge into master to Release 3.18.16

Automatic merge into master to Release 3.18.17

Automatic merge into master to Release 3.18.18

Automatic merge into master to Release 3.18.19

Automatic merge into master to Release 3.18.20

Automatic merge into master to Release 3.18.21

Automatic merge into master to Release 3.18.22

Automatic merge into master to Release 3.18.23

Automatic merge into master to Release 3.18.24

Automatic merge into master to Release 3.18.25

Update version to 3.18.25

Automatic merge into master to Release 3.18.26

Update version to 3.18.26

…y on the url

cristian-situm · 2026-07-10T12:53:42Z

- Patched the Web Share API on Android by overriding `navigator.canShare` and `navigator.share` in the WebView and forwarding share events via `postMessage` to be handled natively using the React Native Share API.
+### Added
+
+- Added JWT token authentication support through `SitumPlugin.setToken()` and the new optional `SitumProvider.token` property.


Que opcion va a tener preferencia en mi app si llamo a las 2 en mi codigo ? Entiendo que la ultima que hayas llamado ? Cual seria la opcion "ideal" o mas normal/idiomatica de usar la autenticacion por token ?

Exacto, se aplica la última a la que hayas llamado. La forma ideal de usarlo es por medio del provider, pues se integra con el flujo de React.
Por otro lado, aclaro que en el provider he hecho que el token tenga prioridad sobre la apikey para evitar posibles errores si mandas los 2 a la vez. A esto tampoco creo que haya que darle muchas vueltas, al final no se deberían utilizar apikey y token a la vez.

Lo he cambiado, ya no hay prioridad, es siempre el último que pasas

Yo reflejaria esta aclaracion en el changelog y en la docu del provider si tiene

SilviaMRegueira · 2026-07-13T08:56:02Z

+        boolean isSuccess = false;
+        try {
+            if (token != null && !token.isEmpty()) {
+            isSuccess = SitumSdk.configuration().setToken(token);


es una tontería pero no está bien indentado

SilviaMRegueira · 2026-07-13T08:59:27Z

+  };
+
+  /**
+   * Provides your token to the Situm SDK.


Mira la documentación que tenemos en los sdks y adaptala para esto

SilviaMRegueira · 2026-07-13T09:05:40Z

+    }, [auth, configuration.situmApiKey]);
+
+    const sendEffectiveAuth = useCallback(() => {
+      if (


porque separas el if en tres lineas?

Lo he cambiado, ahora lo subo

SilviaMRegueira · 2026-07-13T09:12:17Z

      }
    };

+    const effectiveAuth = useMemo<SitumAuth | undefined>(() => {


no entiendo esto del todo. useMemo no se utiliza para que no se vuelva a recalcular este valor?

const effectiveAuth = useMemo<SitumAuth | undefined>(() => {...}, []) ➡️ se calcula una vez al crear el componente

const effectiveAuth = useMemo<SitumAuth | undefined>(() => {...}, [auth, configuration.situmApiKey]) ➡️ se calcula al crearse y cada vez que cambien auth y configuration.situmApiKey

Eu tampouco o termino de entender de todo.
Que pasaría se

O integrador mete apikey ou token no provider ou na configuración?

O integrador mete token ou apikey invalido pero chama os setters?

SilviaMRegueira · 2026-07-13T09:13:04Z

+     * Token renewal is the client's responsibility: update this property or call
+     * `SitumPlugin.setToken()` when a new token is available.
+     *
+     * If both `token` and `apiKey` are specified, `token` takes precedence.


esto ya no es así no? Sería el último que pases

Lo he cambiado, ahora lo subo

adrian-situm · 2026-07-13T13:53:19Z

- Patched the Web Share API on Android by overriding `navigator.canShare` and `navigator.share` in the WebView and forwarding share events via `postMessage` to be handled natively using the React Native Share API.
+### Added
+
+- Added JWT token authentication support through `SitumPlugin.setToken()` and the new optional `SitumProvider.token` property.


Lo he cambiado, ya no hay prioridad, es siempre el último que pasas

adrian-situm · 2026-07-13T13:57:31Z

 export const {
  setWebViewRef,
-  setSdkInitialized,
-  setAuth,


Los he quitado porque no se usaban en ninguna parte y no se estaban sincronizando con el estado del sdk, esta no es la manera intencionada de cambiar el auth y el usuario no debería poder marcar el sdk como no inicializado

Teñen algo que ver cos _setAuth e _setSdkInitialized que están xusto arriba?

adrian-situm · 2026-07-13T14:00:53Z

  const [state, dispatch] = useReducer(store.reducer, {
-    ...store.initialState,
-    user: { email, apiKey },
-    apiDomain: apiDomain,


Ahora se comprueba que no den error en el sdk antes de guardarlos en la store. Si algo da error se quedan como undefined. De todas formas tampoco afecta en nada porque los hijos de este componente no aparecen hasta que se comprueba la autenticación y el api domain, pero así queda más limpio para el futuro.

seguramente se me esta escapando algo, pero non termino de entender os cambios en apiDomain

adrian-situm · 2026-07-13T14:11:05Z

+    } catch (e) {
+      console.error(`SitumProvider > Could not update API domain ${e}`);
+    }
+  }, [apiDomain, dispatch]);


Hubo que separar los props en varios useEffect para que solo se haga el setToken o setApiKey cuando cambie la autenticación.

Esto escápaseme un pouco pero non se poderia facer algo do tipo
if (token){
}
if (apikey){
} e detectar cambios en token, apikey e email

fsvilas · 2026-07-13T11:19:55Z

 	<key>NSMotionUsageDescription</key>
 	<string>We use your phone sensors (giroscope, accelerometer and altimeter) to improve location quality</string>
+	<key>RCTNewArchEnabled</key>
+	<true/>


Porque se activa a nova arquitectura en iOS? De momento o plugin de AR non funciona coa nova arquitectura.

fsvilas · 2026-07-14T09:48:13Z

+    if (token && token.length > 0) {
+        success = [SITServices setToken:token];
+    }
+


Vexo que este método devolve un enteiro en lugar de strings como o resto dos métodos. Esto fixechelo asi porque senon o onCallback non funciona?
xa que export const
handleSyncCallback = (
r: { success: boolean },
errorMessage: string,
) => {
if (r?.success) {
return;
} else {
throw {
code: -1,
message: errorMessage || "Unknown error.",
};
}
}; espera bool e iOS devolve strings no resto dos metodos, non?

Se cadra compensaba arranxa o hadleSyncCallback en lugar de cambiar o patron

fsvilas · 2026-07-14T10:09:09Z

+    /*  Users are intended to change these variables through SitumProvider's props  */
+    _setAuth: (state: State, payload: State["user"]) => {
+      return { ...state, user: payload };
+    },


Porque fai falla engadir o apiDomain, aqui?

fsvilas · 2026-07-14T10:10:18Z

 export const {
  setWebViewRef,
-  setSdkInitialized,
-  setAuth,


Teñen algo que ver cos _setAuth e _setSdkInitialized que están xusto arriba?

fsvilas · 2026-07-14T10:12:34Z

  const [state, dispatch] = useReducer(store.reducer, {
-    ...store.initialState,
-    user: { email, apiKey },
-    apiDomain: apiDomain,


seguramente se me esta escapando algo, pero non termino de entender os cambios en apiDomain

fsvilas · 2026-07-14T10:18:15Z

+    } catch (e) {
+      console.error(`SitumProvider > Could not update API domain ${e}`);
+    }
+  }, [apiDomain, dispatch]);


Esto escápaseme un pouco pero non se poderia facer algo do tipo
if (token){
}
if (apikey){
} e detectar cambios en token, apikey e email

fsvilas · 2026-07-14T10:21:55Z

      }
    };

+    const effectiveAuth = useMemo<SitumAuth | undefined>(() => {


Eu tampouco o termino de entender de todo.
Que pasaría se

O integrador mete apikey ou token no provider ou na configuración?

O integrador mete token ou apikey invalido pero chama os setters?

situmops and others added 30 commits February 20, 2026 11:53

Automatic merge into master to Release 3.18.6

80500b4

Automatic merge into master to Release 3.18.6

Automatic merge into master to Release 3.18.7

f225669

Automatic merge into master to Release 3.18.7

Automatic merge into master to Release 3.18.8

ac5c4d2

Automatic merge into master to Release 3.18.8

Automatic merge into master to Release 3.18.9

d4bc9da

Automatic merge into master to Release 3.18.9

Automatic merge into master to Release 3.18.10

16c31d0

Automatic merge into master to Release 3.18.10

Automatic merge into master to Release 3.18.11

2be003f

Automatic merge into master to Release 3.18.11

Automatic merge into master to Release 3.18.12

857f3a6

Automatic merge into master to Release 3.18.12

Merge pull request #609 from situmtech/release/3.18.13

c6e5312

Automatic merge into master to Release 3.18.13

Automatic merge into master to Release 3.18.14

3411ec5

Automatic merge into master to Release 3.18.14

Automatic merge into master to Release 3.18.15

2a96744

Automatic merge into master to Release 3.18.15

Automatic merge into master to Release 3.18.16

2c0b5fe

Automatic merge into master to Release 3.18.16

Automatic merge into master to Release 3.18.17

8e89e32

Automatic merge into master to Release 3.18.17

Automatic merge into master to Release 3.18.18

aab7c2a

Automatic merge into master to Release 3.18.18

Automatic merge into master to Release 3.18.19

f246476

Automatic merge into master to Release 3.18.19

Automatic merge into master to Release 3.18.20

9e6a2e7

Automatic merge into master to Release 3.18.20

Automatic merge into master to Release 3.18.21

544777c

Automatic merge into master to Release 3.18.21

Automatic merge into master to Release 3.18.22

f3b291c

Automatic merge into master to Release 3.18.22

Automatic merge into master to Release 3.18.23

e039e40

Automatic merge into master to Release 3.18.23

Automatic merge into master to Release 3.18.24

6cf0c7b

Automatic merge into master to Release 3.18.24

Automatic merge into master to Release 3.18.25

bb9dfd1

Automatic merge into master to Release 3.18.25

Merge pull request #637 from situmtech/release/3.18.25

c1c6c03

Update version to 3.18.25

Automatic merge into master to Release 3.18.26

f5456f5

Automatic merge into master to Release 3.18.26

Merge pull request #642 from situmtech/release/3.18.26

6a6c501

Update version to 3.18.26

Added support for token authentication

b2c30cc

Updated react native version

f849990

Added native implementation for setToken

499e817

Fixed the auth being sent to the viewer when loading it with an apike…

22ec8b6

…y on the url

MapView now reloads when changing the apikey

fd61126

Cleaned some logic

0e18307

Added comments and cleaned old logic

ccab37f

Updated changelog

021f572

cristian-situm reviewed Jul 10, 2026

View reviewed changes

Comment thread plugin/src/wayfinding/components/MapView.tsx Outdated

cristian-situm reviewed Jul 10, 2026

View reviewed changes

Comment thread plugin/src/sdk/index.ts

cristian-situm reviewed Jul 10, 2026

View reviewed changes

Comment thread CHANGELOG_UNRELEASED.md

cristian-situm reviewed Jul 10, 2026

View reviewed changes

Comment thread package.json

Small refactors

ca185cb

SilviaMRegueira reviewed Jul 13, 2026

View reviewed changes

adrian-situm added 2 commits July 13, 2026 15:47

Refactors and logic changes to SitumProvider

cf94bc3

Small adjustments

11f885e

adrian-situm commented Jul 13, 2026

View reviewed changes

fsvilas reviewed Jul 14, 2026

View reviewed changes

adrian-situm added 2 commits July 15, 2026 08:10

Simplified logic in SitumProvider and improved changelog

e78e8b0

Merge remote-tracking branch 'origin/develop' into feature/PRD-1032

98c92a3

Uh oh!

Conversation

adrian-situm commented Jul 10, 2026

Uh oh!

Uh oh!

Uh oh!

cristian-situm Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrian-situm Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cristian-situm Jul 10, 2026 •

edited

Loading

adrian-situm Jul 10, 2026 •

edited

Loading